test: make the event-loop regression portable (macOS build fix) - #62
Merged
Conversation
The event-loop-unblocking test forced HELM_CHANNEL_COMPUTER_BACKEND=oci and asserted runtimeReadiness reports ready:true. The OCI backend is only supported on linux and win32, so on the macOS release host the same call correctly returns ready:false and the test failed - a test-portability bug, not a product defect. The two ready-state assertions are now gated on whether OCI is supported on the running platform (linux/win32 + arm64/x64), asserting the correct value either way. The point of the test - that the slow readiness refresh runs off the event loop - is unchanged: the refresh still executes on every platform and the tick-count assertion that actually caught the regression still runs everywhere. Verified: reintroducing execFileSync in the memory bridge still fails the suite, so the guard is not weakened.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe runtime readiness test now derives expected OCI readiness from supported platform and architecture combinations. It continues to verify event-loop responsiveness during asynchronous refresh and cached readiness behavior. ChangesOCI readiness validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.0.40 macOS release build correctly halted at
npm test:Line 79 is
assert.equal(refreshed.ready, true), not a timing assertion. The test forcesHELM_CHANNEL_COMPUTER_BACKEND=oci, but the OCI backend is only supported on linux/win32 (channel-computers.tsgatessupportedonplatform() ∈ {linux, win32}). On the macOS Studio the same call correctly returnsready:false. Test-portability bug, not a product defect — the exact classAGENTS.override.mdwarns about.Fix
The two
ready-state assertions are gated on whether OCI runs on the current platform; each asserts the platform-correct value. The test's actual purpose — that the slow readiness refresh executes off the event loop — is unchanged: the refresh still runs on every platform, and the tick-count assertion that caught the original regression still runs everywhere.Mutation-checked: reintroducing
execFileSyncin the memory bridge still fails the suite.No version bump — this is part of the in-flight 0.0.40 whose artifacts are still being built.
🤖 Generated with Claude Code
Summary by CodeRabbit